Fixes #8519: rudder-dev KeyError: 'master' #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a little bit of refactoring : I moved get_version to redmine.py |
peckpeck
force-pushed
the
bug_8519/rudder_dev_keyerror_master
branch
from
838e9a7
to
ea83a24
Compare
|
Commit modified |
| if bug: | ||
| new_info['tracker_id'] = Config.BUG_TACKER_ID | ||
| new_info['description'] = "There was a bug in the resolution of #" + str(info['id']) | ||
| new_info['description'] = "There was a bug in the resolution of #" + issue.name |
There was a problem hiding this comment.
issue id instead of name?
There was a problem hiding this comment.
or maybe name gives the id of the issue ?
There was a problem hiding this comment.
name is the id + the "i" for internal issues
|
I merge and upmerged your PR automatically -- Your faithful QA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8519