Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6462:Had a few problems using server_ubuntu #12

Merged
merged 1 commit into from Apr 3, 2015

Conversation

mikes1988
Copy link
Contributor

PR fixes #6462

Narrowed problem down to provision/server_ubuntu.sh.

  • Install apache2 before heading towards rudder-server-root.
    • need to run a2enmod version to install mod_version, this is used in the rudder config for apache.
  • fixed the deb sources.list.d lines, contrib and non-free were breaking this.

Narrowed it down to provision/server_ubuntu.sh.

- Install apache2 before heading towards rudder-server-root.
  - need to run a2enmod version to install mod_version, this is used in the rudder config for apache.
- fixed the deb sources.list.d lines, contrib and non-free were breaking this.
@peckpeck
Copy link
Member

peckpeck commented Apr 3, 2015

Thank you mike we will take this one

@fanf
Copy link
Member

fanf commented Apr 3, 2015

Yes, thansk @mikes1988 for the contribution.
Would it be possible to open a ticket on http://www.rudder-project.org/redmine/projects/rudder-tools/ with category "Vagrant" so that we can associate the PR with a bug ? It helps to keep track of why code was added. When done, could you also change the commit text so that it includes "Fixes #XXXX: ....", with XXXX being the ticket id.

For non-trivial contrib, we also ask if you can sign a contributor agreement as explained in http://www.rudder-project.org/foswiki/Development/HowToContribute .

Thanks again for your time and intererest !

EDIT: wow, ordering sentences is hard :)

@mikes1988
Copy link
Contributor Author

Hey @fanf, I've submitted bug on redmine, modified commit message and also submitted the ICLA.

Cheers :-D

@fanf
Copy link
Member

fanf commented Apr 3, 2015

Thanks so much for that !

We're looking at the PR (well, I'm telling someone to do so, mychildren don't seem to want to let me do it :)

@VinceMacBuche
Copy link
Member

Tested your patch, and it works great!

Thanks a lot @mikes1988 :)

Merging your commit

@VinceMacBuche VinceMacBuche changed the title Had a few problems using server_ubuntu Fixes #6462:Had a few problems using server_ubuntu Apr 3, 2015
VinceMacBuche added a commit that referenced this pull request Apr 3, 2015
Fixes #6462:Had a few problems using server_ubuntu
@VinceMacBuche VinceMacBuche merged commit f77bb0d into Normation:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants