Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8118: When a node send reports with a wrong config_id it is never marked as unresponsive #1113

Conversation

fanf
Copy link
Member

@fanf fanf commented Jun 2, 2016

@VinceMacBuche
Copy link
Member

The problem was that we grouped by nodeId/RuleId, so if there wasn't any data in it would have no value ? (and this is treated in the new toCompliance function )

@fanf
Copy link
Member Author

fanf commented Jun 3, 2016

Not only, but part:

  • when grouping like that with the flatmap in the case of nodeId, we could get less nodeIds than ask. For the one not returned, no bar update generated;
  • if the compliance sum was exactly 0, we didn't know what to generate for the bar, so nothing was generated.
    So, this is the cause of the spliting.

@VinceMacBuche VinceMacBuche merged commit c1ad578 into Normation:branches/rudder/3.1 Jun 3, 2016
@fanf fanf deleted the bug_8118/when_a_node_send_reports_with_a_wrong_config_id_it_is_never_marked_as_unresponsive branch March 15, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants