Fixes #8801: Inconsistent hashing algorithms used in passwords generated in the script engine #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
amousset
force-pushed
the
bug_8801/inconsistent_hashing_algorithms_used_in_passwords_generated_in_the_script_engine
branch
from
6f6d875
to
b0f7e25
Compare
| @@ -172,7 +172,7 @@ trait JsLibPassword extends ImplicitGetBytes { | |||
| def aix(algo: String, s: String, salt: String): String = { | |||
| algo.toLowerCase match { | |||
| case "md5" => aixMd5(s) | |||
…ted in the script engine
|
Commit modified |
amousset
force-pushed
the
bug_8801/inconsistent_hashing_algorithms_used_in_passwords_generated_in_the_script_engine
branch
from
b0f7e25
to
5eb490e
Compare
|
This looks good to me, thanks @amousset. I'd really like to get an opinion from @fanf or @VinceMacBuche before merging this though. |
|
Great @amousset ! |
|
Thanks @VinceMacBuche ! Enjoy the rest of your holiday :) |
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8801