Fixes #9195: Quicksearch does not work on "is enable", directive name, and a lot of others #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR rebased |
fanf
force-pushed
the
bug_9195/quicksearch_does_not_work_on_is_enable
branch
from
9a97470
to
420b5e5
Compare
| case RudderRoles => sub(a, token) | ||
| case GroupId => sub(a, token) | ||
| case IsEnabled => bool(a, token) | ||
| case IsDynamic => bool(a, token) |
There was a problem hiding this comment.
Dynamic should also match for 'dynamic' -> true , 'static' -> false
…, and a lot of others
|
PR rebased |
fanf
force-pushed
the
bug_9195/quicksearch_does_not_work_on_is_enable
branch
from
420b5e5
to
fa04458
Compare
|
Looks good to me! Thank you |
|
If you can add unit test for that later on, you'll make me an happy man |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9195