Ref #3303 : Accepted nodes page #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/ last report)
| @@ -150,6 +150,10 @@ class Boot extends Loggable { | |||
| "secure" / "nodeManager" / "searchNodes" | |||
| >> LocGroup("nodeGroup") | |||
|
|
|||
| , Menu("AcceptedNodes", <span>Accepted nodes</span>) / | |||
There was a problem hiding this comment.
Please don't name this page "Accepted nodes". This sounds like it's a list of acceptations. Just call it "Nodes".
|
I made the changes you suggest Jon. |
|
Technical review OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to http://www.rudder-project.org/redmine/issues/3304
to be merged in master/2.6 after #127