Ref #3297 : Add new columns to search node result (os details/ last repo... #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <th>OS type</th> | ||
| <th>OS name</th> | ||
| <th>OS version</th> | ||
| <th>Service Pack</th> |
There was a problem hiding this comment.
This should be "OS service pack" (note "OS" and capitalization) to match the previous lines.
|
I just made the changes you suggest Jon |
…s/ last report)
|
This pull request is rejected, because replaced by #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rt
Linked to http://www.rudder-project.org/redmine/issues/3297
to be merged in master/2.6