Ust 3296/implem 3297/add columns search result machine type #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -234,6 +234,17 @@ class ReportsJdbcRepository(jdbcTemplate : JdbcTemplate) extends ReportsReposito | |||
| } | |||
| } | |||
|
|
|||
| def getNewestReportOnNode(nodeid:NodeId) : Box[Option[Reports]] = { | |||
| jdbcTemplate.query(baseQuery + s" and nodeid = '${nodeid.value}' order by executionDate desc limit 1", | |||
There was a problem hiding this comment.
This is something that hsould never ever be done; as it is a risk for potential SQL injection (imagine a Node with the id '; delete from ruddersysevents; --
You should use the more traditionnal with a prepared statement
jdbcTemplate.query(query,
array.toArray[AnyRef],
ReportsMapper).toSeq;
…s/ last report)
|
Appart from the OsType which is not used anymore, but that we can keep anyway, it's great |
nperron
pushed a commit
that referenced
this pull request
Mar 28, 2013
…olumns_search_result_machine_type Fixes #3297 : Add new columns to search node result (os details/ last report)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to http://www.rudder-project.org/redmine/issues/3297
Not finished yet, but now we get the machine type with a workaround
Maybe we need to change the way node informations are stored.