Fixes #10080: Reorganize Directives page interface #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| maxHeight = 'calc(100vh - '+ offsetTop + 'px)'; | ||
| } | ||
| }else{ | ||
| maxHeight = "none"; |
There was a problem hiding this comment.
You should set maxHeight to "none" by default and do not do the else part
| @@ -1050,6 +1058,46 @@ table.tablewidth{ | |||
| } | |||
|
|
|||
| /* --- DIRECTIVE PAGE --- */ | |||
There was a problem hiding this comment.
I would love to have this in a separate file
directives.css
| @@ -876,7 +876,15 @@ a.sidebar-toggle{ | |||
| position:relative; | |||
| opacity:1; | |||
| } | |||
| /* RULE PAGE */ | |||
There was a problem hiding this comment.
Same here I would love to have it in a separate file, only loaded when needed
|
Ap&art the three small comment this looks ok! |
|
Oops |
|
Commit modified |
RaphaelGauthier
force-pushed
the
ust_10080/reorganize_directives_page_interface
branch
from
2369964
to
8f41451
Compare
| @@ -0,0 +1,78 @@ | |||
| /* --- DIRECTIVES PAGE --- */ | |||
There was a problem hiding this comment.
You need to add the licence lines like in rudder.css
|
Commit modified |
RaphaelGauthier
force-pushed
the
ust_10080/reorganize_directives_page_interface
branch
from
8f41451
to
1bf2440
Compare
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10080