Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10908: When hooks in policy-generation-node-ready or policy-generation-node-finished fails, there is no error in the generation #1664

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Fixes #10908: When hooks in policy-generation-node-ready or policy-generation-node-finished fails, there is no error in the generation #1664

merged 1 commit into from
Jun 14, 2017

Conversation

fanf
Copy link
Member

@fanf fanf commented Jun 14, 2017

ncharles
ncharles approved these changes Jun 14, 2017
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you just fix the typo, and self merge ?

...c/main/scala/com/normation/rudder/services/policies/write/Cf3PromisesFileWriterService.scala Outdated
@@ -267,6 +268,9 @@ class Cf3PromisesFileWriterServiceImpl(
}})
implicit val scheduler = Scheduler.io(executionModel = ExecutionModel.AlwaysAsyncExecution)

//interpret HookReturnCode as a Bow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a Box

...c/main/scala/com/normation/rudder/services/policies/write/Cf3PromisesFileWriterService.scala Outdated
@@ -84,6 +84,7 @@ import scala.language.postfixOps
import com.normation.rudder.hooks.RunHooks
import com.normation.rudder.hooks.HookEnvPairs
import com.normation.rudder.hooks.HooksLogger
import com.normation.rudder.hooks.HooksImplicits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so clever !

@fanf
Fixes #10908: When hooks in policy-generation-node-ready or policy-ge…
d180e30 
…neration-node-finished fails, there is no error in the generation
@fanf
Copy link
Member Author

fanf commented Jun 14, 2017

PR rebased

@fanf fanf force-pushed the bug_10908/when_hooks_in_policy_generation_node_ready_or_policy_generation_node_finished_fails_there_is_no_error_in_the_generation branch from 5cdd077 to d180e30 Compare June 14, 2017 09:24
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit d180e30 into Normation:branches/rudder/4.1 Jun 14, 2017
@fanf fanf deleted the bug_10908/when_hooks_in_policy_generation_node_ready_or_policy_generation_node_finished_fails_there_is_no_error_in_the_generation branch March 15, 2024 10:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles approved these changes

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanf @Normation-Quality-Assistant @ncharles