Fixes #12674: Policies regeneration error when using a parameters with " char #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
May 23, 2018
| , systemVariableSpecService.get("AGENT_TYPE").toVariable(Seq(agentNodeConfig.agentType.toString)) | ||
| , systemVariableSpecService.get("RUDDER_NODE_CONFIG_ID").toVariable(Seq(nodeConfigVersion.value)) | ||
|
|
||
| ).map(x => (x.spec.name, x)).toMap | ||
|
|
||
| for { | ||
| bundleVars <- prepareBundleVars(agentNodeConfig.config.nodeInfo.id, agentNodeConfig.agentType, agentNodeConfig.config.nodeInfo.osDetails | ||
| , agentNodeConfig.config.nodeInfo.policyMode, globalPolicyMode, container) | ||
| paramValues <- Control.sequence(agentNodeConfig.config.parameters.toSeq) { x => |
There was a problem hiding this comment.
did you check that it worked with DSC ?
|
PR rebased |
fanf
force-pushed
the
bug_12674/policies_regeneration_error_when_using_a_parameters_with_char
branch
from
deb0a90
to
7172b78
Compare
ncharles
approved these changes
May 23, 2018
|
PR rebased |
fanf
force-pushed
the
bug_12674/policies_regeneration_error_when_using_a_parameters_with_char
branch
from
7172b78
to
d30fdc8
Compare
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
fanf
deleted the
bug_12674/policies_regeneration_error_when_using_a_parameters_with_char
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12674