Fixes #12702: Method copyResourceFile is quite inefficient #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
requested changes
Jun 27, 2018
| , destination: String | ||
| , content : String //template resource as a file | ||
| ) extends HashcodeCaching { | ||
| override def toString() = s"Promise resource ${id.name}; destination ${destination}" |
There was a problem hiding this comment.
Can you use something else then "promise" here? Technique resource, or policy resource.
There was a problem hiding this comment.
ok, renaming previous message also then
|
Appart for the little comment, this is a very nice pr! Oh: could you try to align "<-" too? |
|
Commit modified |
ncharles
force-pushed
the
bug_12702/method_copyresourcefile_is_quite_inefficient
branch
2 times, most recently
from
aa61ede
to
8c4aed8
Compare
|
Commit modified |
|
Commit modified |
ncharles
force-pushed
the
bug_12702/method_copyresourcefile_is_quite_inefficient
branch
from
8c4aed8
to
3ace7e9
Compare
fanf
approved these changes
Jun 27, 2018
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
|
OK, merging this PR |
1 similar comment
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12702