-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #12702: Method copyResourceFile is quite inefficient #1973
Fixes #12702: Method copyResourceFile is quite inefficient #1973
Conversation
, destination: String | ||
, content : String //template resource as a file | ||
) extends HashcodeCaching { | ||
override def toString() = s"Promise resource ${id.name}; destination ${destination}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use something else then "promise" here? Technique resource, or policy resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, renaming previous message also then
Appart for the little comment, this is a very nice pr! Oh: could you try to align "<-" too? |
Commit modified |
aa61ede
to
8c4aed8
Compare
Commit modified |
Commit modified |
8c4aed8
to
3ace7e9
Compare
This PR is not mergeable to upper versions. |
OK, merging this PR |
OK, merging this PR |
1 similar comment
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/12702