Fixes #15434: Cannot start relayd #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
approved these changes
Aug 8, 2019
|
OK, merging this PR |
ncharles
commented
Aug 8, 2019
| @@ -96,14 +100,18 @@ class WriteNodeCertificatesPemImpl(reloadScriptPath: Option[String]) extends Wri | |||
| })} | |||
| writen <- writeCertificatesToNew(allCertsNew, certs) | |||
| moved <- IOResult.effect(allCertsNew.moveTo(file, overwrite = true)) | |||
| //perm <- IOResult.effect(file.setGroup("rudder")) -> fails with SystemError: An error occured; cause was: java.io.IOException: 'owner' parameter can't be a group | |||
There was a problem hiding this comment.
pointing this sadeness to @fanf so that he'll have an enlighted advice
fanf
reviewed
Aug 12, 2019
There was a problem hiding this comment.
@ncharles : I think it should be reported to better files, if possible with a minimized case. If really just file.setGroup("some group") fails, it seems pretty important to report. If not, the minimization case could help understand what going on.
|
For reference, it's trivial to reproduce and it's now reported here: pathikrit/better-files#332 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15434