Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15792: When writing policies, we replace the RudderUniqueId with replaceAll which is twice as slow as StringUtils.replace #2482

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Fixes #15792: When writing policies, we replace the RudderUniqueId with replaceAll which is twice as slow as StringUtils.replace #2482

merged 1 commit into from
Sep 25, 2019

Conversation

ncharles
Copy link
Member

@ncharles
Fixes #15792: When writing policies, we replace the RudderUniqueId wi…
40f23bf 
…th replaceAll which is twice as slow as StringUtils.replace
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2482
-- Your faithful QA
Kant merge: "Science is organized knowledge. Wisdom is organized life."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/15214/console)

@fanf
Copy link
Member

fanf commented Sep 24, 2019

OK, merging this PR

1 similar comment
@ncharles
Copy link
Member Author

OK, merging this PR

@ncharles ncharles merged commit 40f23bf into Normation:branches/rudder/5.0 Sep 25, 2019
@fanf
Copy link
Member

fanf commented Sep 25, 2019

OK, merging this PR

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncharles @Normation-Quality-Assistant @fanf