Fixes #15809: Cannot update editor techniques at webapp startup if the request to get techniques timeout (5 seconds) #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e request to get techniques timeout (5 seconds)
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_15809/cannot_update_editor_techniques_at_webapp_startup_if_the_request_to_get_techniques_timeout_5_seconds
branch
from
2f08a45
to
64c63e0
Compare
fanf
requested changes
Oct 1, 2019
| @@ -193,15 +193,19 @@ class TechniqueWriter ( | |||
| } | |||
|
|
|||
| // Write and commit all techniques files | |||
| def writeAll(technique : Technique, methods: Map[BundleName, GenericMethod], modId : ModificationId, committer : EventActor) : Result[Seq[String]] = { | |||
| def writeAll(technique : Technique, methods: Map[BundleName, GenericMethod], modId : ModificationId, committer : EventActor, launchLibUpdate : Boolean) : Result[Seq[String]] = { | |||
There was a problem hiding this comment.
boolean option are hard to understand (we should never have one I believe). I think we should have two methods here: writeAll and writeAllAndUpdateTechLib and just call the correct one in either place.
…e request to get techniques timeout (5 seconds)
VinceMacBuche
force-pushed
the
bug_15809/cannot_update_editor_techniques_at_webapp_startup_if_the_request_to_get_techniques_timeout_5_seconds
branch
from
64c63e0
to
542bdc7
Compare
|
Commit modified |
fanf
approved these changes
Oct 3, 2019
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15809