Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16083: Big memory usage when fetching/writing ndoe configuration and expected reports #2569

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Fixes #16083: Big memory usage when fetching/writing ndoe configuration and expected reports #2569

merged 1 commit into from
Nov 15, 2019

Conversation

ncharles
Copy link
Member

@ncharles
Copy link
Member Author

PR updated with a new commit

@ncharles ncharles force-pushed the bug_16083/big_memory_usage_when_fetching_writing_ndoe_configuration_and_expected_reports branch from f7e2394 to 4165f67 Compare October 31, 2019 14:07
@ncharles
Copy link
Member Author

Commit modified

@ncharles ncharles force-pushed the bug_16083/big_memory_usage_when_fetching_writing_ndoe_configuration_and_expected_reports branch from 4165f67 to 4c6e32f Compare October 31, 2019 15:10
@ncharles
Copy link
Member Author

Commit modified

@ncharles
Copy link
Member Author

PR updated with a new commit

@ncharles ncharles force-pushed the bug_16083/big_memory_usage_when_fetching_writing_ndoe_configuration_and_expected_reports branch from 6ee2b62 to c4d6c85 Compare October 31, 2019 21:28
@ncharles
Copy link
Member Author

Commit modified

@ncharles ncharles force-pushed the bug_16083/big_memory_usage_when_fetching_writing_ndoe_configuration_and_expected_reports branch from c4d6c85 to af26b8b Compare October 31, 2019 22:17
@ncharles
Copy link
Member Author

Commit modified

fanf
fanf requested changes Nov 12, 2019
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that one. It means that we loose the atomicity property and so, we could be in a case where we have a failed generation with some commited (and not other) expected reports.
AFAIU, the problem is the query (ie string) size. What could be a better solution, if available, is to strart transaction, stream changes, commit transaction - but I don't know how to do it. I propose to postpone that one for now to study that possibility.

@ncharles
Copy link
Member Author

I can split the PR in two, one for the read, that don't need to be atomic, and post-pone the writing part that need atomicity

@ncharles
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2569
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/17241/console)

@fanf
Copy link
Member

fanf commented Nov 15, 2019

OK, squash merging this PR

@fanf fanf force-pushed the bug_16083/big_memory_usage_when_fetching_writing_ndoe_configuration_and_expected_reports branch from f07a8f5 to bc70f08 Compare November 15, 2019 14:11
@fanf fanf merged commit bc70f08 into Normation:branches/rudder/5.0 Nov 15, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncharles @Normation-Quality-Assistant @fanf