-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16122: Stop listenning for inventories on port 80 #2572
Fixes #16122: Stop listenning for inventories on port 80 #2572
Conversation
@@ -1,12 +1,5 @@ | |||
DocumentRoot /var/www | |||
|
|||
<FilesMatch "\.(cgi|shtml|phtml|php)$"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason behind this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed
@@ -17,79 +10,3 @@ DocumentRoot /var/www | |||
</IfModule> | |||
</IfModule> | |||
|
|||
# Expose the server UUID through http | |||
Alias /uuid /opt/rudder/etc/uuid.hive | |||
<Directory /opt/rudder/etc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this used by the inventory code ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to always use https in 5.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also checked usage of relay API, we are using https or ${inventory_protocol} (which is https now) everywhere.
This PR breaks qa-test
You should run ./qa-test in your repository to make sure it works. |
OK, merging this PR |
https://issues.rudder.io/issues/16122