-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports #2754
Conversation
this is a WIP. I'll ensure that getNodeStatusReports return merged data, and don't use merge in all method calling it |
PR updated with a new commit |
10 similar comments
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
This version caused a FullGC during policy compliance computation + writting policies |
PR updated with a new commit |
1 similar comment
PR updated with a new commit |
ping @fanf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appart from trivial remark, this seems good!
, complianceLevel.complianceWithoutPending.round | ||
)) | ||
} | ||
// global = reportingService.computeComplianceFromReports(reports) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments here and on l208
PR updated with a new commit |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
Fixes #16661: inneficient computation of RuleStatusReports and NodeStatusReports
3c41f78
to
8723a34
Compare
OK, merging this PR |
https://issues.rudder.io/issues/16661