Fixes #16737: rl variables throw error if variable names are the same #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpoblon
force-pushed
the
ust_16737/rl_variables_throw_error_if_variable_names_are_the_same
branch
from
4e2251e
to
ba82ba9
Compare
|
rebased + got it ready to be merged into master |
gpoblon
force-pushed
the
ust_16737/rl_variables_throw_error_if_variable_names_are_the_same
branch
from
ba82ba9
to
57077f5
Compare
peckpeck
requested changes
Feb 20, 2020
|
Commit modified |
gpoblon
force-pushed
the
ust_16737/rl_variables_throw_error_if_variable_names_are_the_same
branch
from
57077f5
to
9e41ba4
Compare
|
PR updated with a new commit |
added 2 commits
February 20, 2020 16:41
…he same Fixes #16737: rl variables throw error if variable names are the same
|
PR rebased |
gpoblon
force-pushed
the
ust_16737/rl_variables_throw_error_if_variable_names_are_the_same
branch
from
5b3d4af
to
87d8028
Compare
peckpeck
reviewed
Feb 20, 2020
…s are the same Fixes #16737: rl variables throw error if variable names are the same
|
PR updated with a new commit |
peckpeck
approved these changes
Feb 26, 2020
|
@gpoblon conflicts -> you ust rebase |
…able_names_are_the_same
peckpeck
approved these changes
Feb 26, 2020
|
OK, squash merging this PR |
|
Merged, but due to multiple rebases this might not have been detected |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16737