Fixes #17075: translation into rudder-lang doesn't handle any class #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also contains a litte rewrite to always have a translation context and some bugfix in oslib |
peckpeck
commented
Apr 7, 2020
| fn translate_condition(&self, expr: &str) -> Result<String> { | ||
| lazy_static! { | ||
| static ref CLASS_RE: Regex = Regex::new(r"([\w${}.]+)").unwrap(); | ||
| static ref ANY_RE: Regex = Regex::new(r"(any\.)").unwrap(); |
There was a problem hiding this comment.
The interesting part is this, and the replace below
amousset
approved these changes
Apr 14, 2020
|
OK, merging this PR |
peckpeck
deleted the
bug_17075/translation_into_rudder_lang_doesn_t_handle_any_class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17075