Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17937: replace var keyword by let #3129

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fixes #17937: replace var keyword by let #3129

merged 1 commit into from
Jul 23, 2020

Conversation

gpoblon
Copy link
Contributor

@gpoblon gpoblon commented Jul 17, 2020

@gpoblon gpoblon requested a review from amousset July 17, 2020 13:17
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3129
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/27831/console)

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3129
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/27939/console)

@gpoblon
Copy link
Contributor Author

gpoblon commented Jul 23, 2020

OK, merging this PR

5 similar comments
@gpoblon
Copy link
Contributor Author

gpoblon commented Jul 23, 2020

OK, merging this PR

@gpoblon
Copy link
Contributor Author

gpoblon commented Jul 23, 2020

OK, merging this PR

@gpoblon
Copy link
Contributor Author

gpoblon commented Jul 23, 2020

OK, merging this PR

@gpoblon
Copy link
Contributor Author

gpoblon commented Jul 23, 2020

OK, merging this PR

@gpoblon
Copy link
Contributor Author

gpoblon commented Jul 23, 2020

OK, merging this PR

@gpoblon gpoblon merged commit 0c8df9f into Normation:branches/rudder/6.1 Jul 23, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpoblon @Normation-Quality-Assistant @amousset