Fixes #17950: testing loop should report an error when rudderc does #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Jul 23, 2020
rudder-lang/tools/tester.sh
Outdated
| ${cfjson_tester} ncf-to-json --config-file=${config_file} "${technique_path}" "${technique}.json" && status=${status}+1 \ | ||
| && ${rudderc} --config-file=${config_file} --translate -s "${technique}.json" && status=${status}+1 \ | ||
| && ${rudderc} --config-file=${config_file} -s "${technique}.rl" && status=${status}+1 \ | ||
| && ${cfjson_tester} ncf-to-json --config-file="${config_file}" "${technique}.rl.cf" "${technique}.rl.cf.json" && status=${status}+1 \ |
There was a problem hiding this comment.
status=${status}+1 it not proper shell you must write
status=$((
peckpeck
approved these changes
Jul 23, 2020
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
gpoblon
force-pushed
the
bug_17950/testing_loop_should_report_an_error_when_rudderc_does
branch
from
a3a9c20
to
cb6994e
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17950