Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18275: internally use a more secured version type for techniques version #3236

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Fixes #18275: internally use a more secured version type for techniques version #3236

merged 1 commit into from
Oct 7, 2020

Conversation

gpoblon
Copy link
Contributor

@gpoblon gpoblon commented Oct 1, 2020

@gpoblon gpoblon requested a review from peckpeck October 1, 2020 12:09
@gpoblon gpoblon force-pushed the ust_18275/internally_use_a_more_secured_version_type_for_techniques_version branch from c05c9db to 9b4b1f9 Compare October 6, 2020 10:11
@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 6, 2020

Commit modified

@gpoblon gpoblon force-pushed the ust_18275/internally_use_a_more_secured_version_type_for_techniques_version branch from 9b4b1f9 to b96c5ce Compare October 6, 2020 13:47
@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 6, 2020

Commit modified

@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 7, 2020

PR updated with a new commit

amousset
amousset reviewed Oct 7, 2020
View reviewed changes
rudder-lang/src/output.rs Outdated Show resolved Hide resolved
@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 7, 2020

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3236
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/30660/console)

@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 7, 2020

OK, squash merging this PR

@gpoblon gpoblon force-pushed the ust_18275/internally_use_a_more_secured_version_type_for_techniques_version branch from 3d026cc to 0115f49 Compare October 7, 2020 10:48
@gpoblon gpoblon merged commit 0115f49 into Normation:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset left review comments

@peckpeck peckpeck peckpeck approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpoblon @Normation-Quality-Assistant @amousset @peckpeck