Fixes #3967 : Handle carriage return in change request xml #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, the debugging is an other pull request, in an other ticket - perhaps even only in 2.8, and perhaps with a special logger so that user can enable only that one. |
|
I've corrected the pull request !! I created another branch containing the debug logs. I'll create another issue to handle them. |
|
closing this one, replaced by #326 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/3967
Should I made another pull request about the debug log lines ?
They will be very useful to debug change request in the future (just have to say to activate debug logs)