Fixes #18694: Rudder-pkg fails at upgrade when no newer version of a plugin are available #3425
Conversation
| @@ -350,20 +350,21 @@ def upgrade_all(mode): | |||
| currentVersion = rpkg.PluginVersion(utils.DB["plugins"][p]["version"]) | |||
| pkgs = plugin.Plugin(p) | |||
| pkgs.getAvailablePackages() | |||
| latestversion = None | |||
There was a problem hiding this comment.
I would have put currentVersion in latestVersion, so we don't have to check if it is None
| if mode == "nightly": | ||
| latest_packages = pkgs.getLatestCompatibleNightly() | ||
| if (latest_packages is None): | ||
| print("No newer %s compatible versions found for the plugin %s"%(mode, p)) | ||
| logging.error("No newer %s compatible versions found for the plugin %s"%(mode, p)) |
There was a problem hiding this comment.
I don't think that's an error but an info and maybe we can get rid of that message here because it will be also printed at the end by a logging.info
There was a problem hiding this comment.
I think we should only do the else par (with is not None in if)
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…plugin are available
Fdall
force-pushed
the
bug_18694/rudder_pkg_fails_at_upgrade_when_no_newer_version_of_a_plugin_are_available
branch
from
9e4202c
to
ef7bfae
Compare
https://issues.rudder.io/issues/18694