Fixes #18900: Missing exception details in change request update #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
commented
Feb 16, 2021
| @@ -538,6 +538,7 @@ class ModificationValidationPopup( | |||
| case eb:EmptyBox => | |||
| val e = eb ?~! "Error when moving the group (no change request was created)" | |||
| //early return here | |||
| logger.error(e.messageChain) | |||
| e.chain.foreach { ex => | |||
There was a problem hiding this comment.
the foreach here only tests the e parent (ie eb) exists and is non-empty and display its messageChain but doesn't log it (I'm not sure why, but I prefer not to change that).
VinceMacBuche
approved these changes
Mar 10, 2021
|
OK, merging this PR |
fanf
deleted the
bug_18900/missing_exception_details_in_change_request_update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18900