Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19243: Improve script linter in rudder repo #3632

Merged
merged 1 commit into from
May 10, 2021
Merged

Fixes #19243: Improve script linter in rudder repo #3632

merged 1 commit into from
May 10, 2021

Conversation

amousset
Copy link
Member

@amousset amousset force-pushed the arch_19243/improve_script_linter_in_rudde_repo branch from 7ad90c8 to fa6089e Compare May 10, 2021 15:27
@amousset
Copy link
Member Author

Do not merge, I'm checking for actual failures for now

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset changed the title Fixes #19243: Improve script linter in rudde repo Fixes #19243: Improve script linter in rudder repo May 10, 2021
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3632
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/38706/console)

@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset force-pushed the arch_19243/improve_script_linter_in_rudde_repo branch 2 times, most recently from feac612 to ac304c0 Compare May 10, 2021 15:50
@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset force-pushed the arch_19243/improve_script_linter_in_rudde_repo branch from ac304c0 to 7541194 Compare May 10, 2021 15:56
@amousset
Copy link
Member Author

OK, merging this PR

@amousset amousset merged commit 091c5b8 into Normation:branches/rudder/6.1 May 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Trigger test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amousset @Normation-Quality-Assistant @VinceMacBuche