-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #19537: Add Kali Linux to the list of recognized OS #3720
Fixes #19537: Add Kali Linux to the list of recognized OS #3720
Conversation
9c61dd3
to
e4bf8a2
Compare
Commit modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add:
- an entry for kali in
rudder-node.css
(around line 270) for kali logo in node details, - the logo at the corresponding place,
- an entry in
os.yml
for api doc
Appart from that, seems OK. Did you checked with an other added distro (like scientific) PR if everything is there ?
I looked for amazon linux, and you seems to have all the case covered. |
e4bf8a2
to
a1207fb
Compare
Commit modified |
a1207fb
to
bfe7ad6
Compare
Commit modified |
This PR is not mergeable to upper versions. |
OK, merging this PR |
https://issues.rudder.io/issues/19537