Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19612: Update all java dependencies to latests version for Rudder 7.0 #3749

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 29, 2021

@fanf fanf requested a review from ncharles July 29, 2021 15:29
@fanf fanf force-pushed the arch_19612/update_all_java_dependencies_to_latests_version_for_rudder_7_0 branch from 3d2499f to 29a010f Compare July 29, 2021 15:45
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is breaking compatibility with java 8

<json-smart-version>2.3.1</json-smart-version> <!-- json path dependency -->
<sourcecode-version>0.2.7</sourcecode-version>
<quicklens-version>1.7.4</quicklens-version>
<hikaricp-version>5.0.0</hikaricp-version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.0.0 requires Java 11 - we still support Java 8, so it should be 4.0.3

Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to stay compatible with java 8

<cafeine-version>2.8.6</cafeine-version>
<jgrapht-version>1.4.0</jgrapht-version>
<jgrapht-version>1.5.1</jgrapht-version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.5 is compatible with java 11 only, we need to stay to 1.4.0

@ncharles
Copy link
Member

this fails with following error on the browser

Error locating template: /index.html
Message: scala.xml.parsing.NoBindingFactoryAdapter.scopeStack()Lscala/collection/mutable/Stack;

java.lang.NoSuchMethodError: scala.xml.parsing.NoBindingFactoryAdapter.scopeStack()Lscala/collection/mutable/Stack;net.liftweb.util.Html5Parser.$anonfun$parse$1(HtmlParser.scala:373)
net.liftweb.common.Tryo.tryo(Tryo.scala:22)
net.liftweb.common.Tryo.tryo$(Tryo.scala:20)
net.liftweb.util.Helpers$.tryo(Helpers.scala:34)
net.liftweb.common.Tryo.tryo(Tryo.scala:64)
net.liftweb.common.Tryo.tryo$(Tryo.scala:64)
net.liftweb.util.Helpers$.tryo(Helpers.scala:34)
net.liftweb.util.Html5Parser.parse(HtmlParser.scala:346)
net.liftweb.util.Html5Parser.parse$(HtmlParser.scala:345)
net.liftweb.util.Html5$.parse(HtmlParser.scala:30)
net.liftweb.http.Html5Properties.$anonfun$htmlParser$2(HtmlProperties.scala:344)
net.liftweb.http.LiftRules.$anonfun$contentParsers$1(LiftRules.scala:1528)
net.liftweb.http.ContentParser$$anon$2.parse(ContentParser.scala:99)
net.liftweb.http.Templates$.$anonfun$findRawTemplate0$2(Templates.scala:200)
net.liftweb.http.LiftRules.$anonfun$doWithResource$2(LiftRules.scala:1450)
net.liftweb.common.Full.map(Box.scala:856)
net.liftweb.http.LiftRules.doWithResource(LiftRules.scala:1450)
net.liftweb.http.Templates$.findRawTemplate0(Templates.scala:200)
net.liftweb.http.Templates$.findTopLevelTemplate(Templates.scala:65)
net.liftweb.http.LiftSession.findVisibleTemplate(LiftSession.scala:1331)
net.liftweb.http.LiftSession.$anonfun$processTemplate$2(LiftSession.scala:978)
net.liftweb.common.EmptyBox.or(Box.scala:914)
net.liftweb.http.LiftSession.$anonfun$processTemplate$1(LiftSession.scala:978)
net.liftweb.util.AnyVarTrait.doWith(AnyVar.scala:278)
net.liftweb.util.AnyVarTrait.doWith$(AnyVar.scala:274)
net.liftweb.util.AnyVar.doWith(AnyVar.scala:91)
net.liftweb.http.LiftSession.processTemplate(LiftSession.scala:978)
net.liftweb.http.LiftSession.$anonfun$processRequest$9(LiftSession.scala:1088)
net.liftweb.common.EmptyBox.or(Box.scala:914)
net.liftweb.http.LiftSession.$anonfun$processRequest$6(LiftSession.scala:1088)
net.liftweb.util.StackableMaker.doWith(Maker.scala:153)
net.liftweb.util.StackableMaker.doWith$(Maker.scala:149)
net.liftweb.http.Factory$FactoryMaker.doWith(Factory.scala:37)
net.liftweb.util.StackableMaker.doWith(Maker.scala:144)
net.liftweb.util.StackableMaker.doWith$(Maker.scala:143)
net.liftweb.http.Factory$FactoryMaker.doWith(Factory.scala:37)
net.liftweb.http.LiftSession.$anonfun$processRequest$4(LiftSession.scala:1087)
net.liftweb.http.LiftSession.checkStatelessInSiteMap(LiftSession.scala:1026)
net.liftweb.http.LiftSession.$anonfun$processRequest$3(LiftSession.scala:1082)
net.liftweb.common.EmptyBox.or(Box.scala:914)
net.liftweb.http.LiftSession.processRequest(LiftSession.scala:1080)
net.liftweb.http.LiftServlet.net$liftweb$http$LiftServlet$$dispatchStatefulRequest(LiftServlet.scala:542)
net.liftweb.http.LiftServlet$StatefulResponse$.$anonfun$process$4(LiftServlet.scala:384)
net.liftweb.http.S.wrapQuery(S.scala:1577)
net.liftweb.http.S.$anonfun$_nest2InnerInit$2(S.scala:1744)
net.liftweb.http.S.doAround(S.scala:1506)
net.liftweb.http.S.$anonfun$_nest2InnerInit$1(S.scala:1732)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S._nest2InnerInit(S.scala:1731)
net.liftweb.http.S.$anonfun$_innerInit$5(S.scala:1777)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S.$anonfun$withReq$2(S.scala:1788)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S.withReq(S.scala:1787)
net.liftweb.http.S.withReq$(S.scala:1785)
net.liftweb.http.S$.withReq(S.scala:46)
net.liftweb.http.S.$anonfun$_innerInit$4(S.scala:1772)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S.$anonfun$_innerInit$3(S.scala:1770)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S.$anonfun$_innerInit$2(S.scala:1770)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S.$anonfun$_innerInit$1(S.scala:1769)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S._innerInit(S.scala:1768)
net.liftweb.http.S.$anonfun$_init$7(S.scala:1810)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S.$anonfun$_init$6(S.scala:1808)
net.liftweb.http.CoreRequestVarHandler.apply(Vars.scala:606)
net.liftweb.http.CoreRequestVarHandler.apply$(Vars.scala:592)
net.liftweb.http.RequestVarHandler$.apply(Vars.scala:508)
net.liftweb.http.S.$anonfun$_init$5(S.scala:1808)
net.liftweb.http.CoreRequestVarHandler.apply(Vars.scala:606)
net.liftweb.http.CoreRequestVarHandler.apply$(Vars.scala:592)
net.liftweb.http.TransientRequestVarHandler$.apply(Vars.scala:521)
net.liftweb.http.S.$anonfun$_init$4(S.scala:1807)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S.$anonfun$_init$3(S.scala:1806)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S.$anonfun$_init$2(S.scala:1805)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.S._init(S.scala:1804)
net.liftweb.http.S.init(S.scala:1381)
net.liftweb.http.S.init$(S.scala:1375)
net.liftweb.http.S$.init(S.scala:46)
net.liftweb.http.LiftServlet$StatefulResponse$.doSession$1(LiftServlet.scala:384)
net.liftweb.http.LiftServlet$StatefulResponse$.process(LiftServlet.scala:393)
net.liftweb.http.LiftServlet.stepThroughPipeline$1(LiftServlet.scala:427)
net.liftweb.http.LiftServlet.doService(LiftServlet.scala:435)
net.liftweb.http.LiftServlet.$anonfun$service$2(LiftServlet.scala:162)
net.liftweb.http.LiftServlet.$anonfun$service$2$adapted(LiftServlet.scala:162)
net.liftweb.http.StandardServiceTimer$.$anonfun$logTime$1(ServiceRequestTimer.scala:19)
net.liftweb.util.TimeHelpers.calcTime(TimeHelpers.scala:427)
net.liftweb.util.TimeHelpers.calcTime$(TimeHelpers.scala:425)
net.liftweb.util.Helpers$.calcTime(Helpers.scala:34)
net.liftweb.util.TimeHelpers.logTime(TimeHelpers.scala:446)
net.liftweb.util.TimeHelpers.logTime$(TimeHelpers.scala:445)
net.liftweb.util.Helpers$.logTime(Helpers.scala:34)
net.liftweb.http.StandardServiceTimer$.logTime(ServiceRequestTimer.scala:18)
net.liftweb.http.LiftServlet.doIt$1(LiftServlet.scala:162)
net.liftweb.http.LiftServlet.service(LiftServlet.scala:166)
net.liftweb.http.provider.HTTPProvider.$anonfun$service$7(HTTPProvider.scala:72)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.URLRewriter$.doWith(Req.scala:1357)
net.liftweb.http.provider.HTTPProvider.$anonfun$service$4(HTTPProvider.scala:71)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.provider.HTTPProvider.$anonfun$service$3(HTTPProvider.scala:70)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.provider.HTTPProvider.service(HTTPProvider.scala:60)
net.liftweb.http.provider.HTTPProvider.service$(HTTPProvider.scala:55)
net.liftweb.http.LiftFilter.service(LiftServlet.scala:1063)
net.liftweb.http.provider.servlet.ServletFilterProvider.$anonfun$doFilter$3(ServletFilterProvider.scala:83)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
net.liftweb.http.provider.servlet.ServletFilterProvider.handleLoan$1(ServletFilterProvider.scala:59)
net.liftweb.http.provider.servlet.ServletFilterProvider.handleLoanWrappers(ServletFilterProvider.scala:63)
net.liftweb.http.provider.servlet.ServletFilterProvider.$anonfun$doFilter$2(ServletFilterProvider.scala:82)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
net.liftweb.http.CoreRequestVarHandler.$anonfun$apply$6(Vars.scala:612)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.CoreRequestVarHandler.$anonfun$apply$5(Vars.scala:611)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.CoreRequestVarHandler.$anonfun$apply$4(Vars.scala:611)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.CoreRequestVarHandler.$anonfun$apply$3(Vars.scala:610)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.CoreRequestVarHandler.apply(Vars.scala:609)
net.liftweb.http.CoreRequestVarHandler.apply$(Vars.scala:592)
net.liftweb.http.RequestVarHandler$.apply(Vars.scala:508)
net.liftweb.http.provider.servlet.ServletFilterProvider.$anonfun$doFilter$1(ServletFilterProvider.scala:77)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
net.liftweb.http.CoreRequestVarHandler.$anonfun$apply$6(Vars.scala:612)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.CoreRequestVarHandler.$anonfun$apply$5(Vars.scala:611)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.CoreRequestVarHandler.$anonfun$apply$4(Vars.scala:611)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.CoreRequestVarHandler.$anonfun$apply$3(Vars.scala:610)
net.liftweb.util.ThreadGlobal.doWith(ThreadGlobal.scala:71)
net.liftweb.http.CoreRequestVarHandler.apply(Vars.scala:609)
net.liftweb.http.CoreRequestVarHandler.apply$(Vars.scala:592)
net.liftweb.http.TransientRequestVarHandler$.apply(Vars.scala:521)
net.liftweb.http.provider.servlet.ServletFilterProvider.doFilter(ServletFilterProvider.scala:75)
net.liftweb.http.provider.servlet.ServletFilterProvider.doFilter$(ServletFilterProvider.scala:69)
net.liftweb.http.LiftFilter.doFilter(LiftServlet.scala:1063)
org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:327)
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:115)
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:81)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:121)
org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:115)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:126)
org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:81)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:105)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:149)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:63)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:218)
org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:212)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.header.HeaderWriterFilter.doHeadersAfter(HeaderWriterFilter.java:90)
org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:75)
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:55)
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:110)
org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:80)
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:336)
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:211)
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:183)
org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:358)
org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:271)
org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:201)
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:548)
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:602)
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1435)
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:501)
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1350)
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:191)
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
org.eclipse.jetty.server.Server.handle(Server.java:516)
org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:388)
org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:633)
org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:380)
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:279)
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.produce(EatWhatYouKill.java:135)
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:882)
org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1036)
java.lang.Thread.run(Thread.java:748)

<logback-version>1.2.3</logback-version>
<junit-version>4.13.1</junit-version>
<jodatime-version>2.10.7</jodatime-version>
<scala-xml-version>2.0.1</scala-xml-version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lift need scala xml 1.3.0 i think https://github.com/lift/framework/releases

Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with scala xml 1.3.0, it works like a charm

<logback-version>1.2.3</logback-version>
<junit-version>4.13.1</junit-version>
<jodatime-version>2.10.7</jodatime-version>
<scala-xml-version>2.0.1</scala-xml-version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<scala-xml-version>2.0.1</scala-xml-version>
<scala-xml-version>1.3.0</scala-xml-version>

@ncharles
Copy link
Member

you can change scala-xml back to 1.3.0 and self merge

@fanf fanf force-pushed the arch_19612/update_all_java_dependencies_to_latests_version_for_rudder_7_0 branch from 085f26f to 2e24d87 Compare July 30, 2021 00:46
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 2e24d87 into Normation:master Jul 30, 2021
<sourcecode-version>0.2.7</sourcecode-version>
<quicklens-version>1.7.4</quicklens-version>
<hikaricp-version>4.0.3</hikaricp-version>
<nuprocess-version>2.0.2</nuprocess-version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks command executions: brettwooldridge/NuProcess#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants