-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #19612: Update all java dependencies to latests version for Rudder 7.0 #3749
Conversation
3d2499f
to
29a010f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is breaking compatibility with java 8
webapp/sources/pom.xml
Outdated
<json-smart-version>2.3.1</json-smart-version> <!-- json path dependency --> | ||
<sourcecode-version>0.2.7</sourcecode-version> | ||
<quicklens-version>1.7.4</quicklens-version> | ||
<hikaricp-version>5.0.0</hikaricp-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.0.0 requires Java 11 - we still support Java 8, so it should be 4.0.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to stay compatible with java 8
webapp/sources/pom.xml
Outdated
<cafeine-version>2.8.6</cafeine-version> | ||
<jgrapht-version>1.4.0</jgrapht-version> | ||
<jgrapht-version>1.5.1</jgrapht-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.5 is compatible with java 11 only, we need to stay to 1.4.0
this fails with following error on the browser Error locating template: /index.html java.lang.NoSuchMethodError: scala.xml.parsing.NoBindingFactoryAdapter.scopeStack()Lscala/collection/mutable/Stack;net.liftweb.util.Html5Parser.$anonfun$parse$1(HtmlParser.scala:373) |
webapp/sources/pom.xml
Outdated
<logback-version>1.2.3</logback-version> | ||
<junit-version>4.13.1</junit-version> | ||
<jodatime-version>2.10.7</jodatime-version> | ||
<scala-xml-version>2.0.1</scala-xml-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lift need scala xml 1.3.0 i think https://github.com/lift/framework/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with scala xml 1.3.0, it works like a charm
webapp/sources/pom.xml
Outdated
<logback-version>1.2.3</logback-version> | ||
<junit-version>4.13.1</junit-version> | ||
<jodatime-version>2.10.7</jodatime-version> | ||
<scala-xml-version>2.0.1</scala-xml-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<scala-xml-version>2.0.1</scala-xml-version> | |
<scala-xml-version>1.3.0</scala-xml-version> |
you can change scala-xml back to 1.3.0 and self merge |
085f26f
to
2e24d87
Compare
OK, merging this PR |
<sourcecode-version>0.2.7</sourcecode-version> | ||
<quicklens-version>1.7.4</quicklens-version> | ||
<hikaricp-version>4.0.3</hikaricp-version> | ||
<nuprocess-version>2.0.2</nuprocess-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks command executions: brettwooldridge/NuProcess#128
https://issues.rudder.io/issues/19612