Fixes #19873: Saving a rule with deleted directives/groups does not correct it #3855
Conversation
| |> List.sortWith (compareOn .displayName) | ||
| directives = | ||
| let | ||
| knownDirectives = model.directives |
There was a problem hiding this comment.
Could have been done in one go, but with the sort lost with function from List.Extra
ids
|> List.map (\id ->
model.directives
|> List.Extra.find (.id >> (==) id)
|> Maybe.withDefault (Directive id ("Missing directive with ID "++id.value) "" "" "" False False "")
)
|> List.sortWith (compareOn .displayName)
There was a problem hiding this comment.
Anyway that does not sort the unknown directive to the end, maybe with List.extra.span
There was a problem hiding this comment.
that's not important: this is only a workaround for a case that should be rare, and you just want to remove them all in all case.
There was a problem hiding this comment.
hum, perhaps I didn't understood - did you mean 1/ "that unknow directives, which in the end, are not sorted (on ID for ex)" or "the unknow directives get mixed with the known one?". I understood 1/, but if it was 2/: they are well all grouped together in the end, because of the List.append
|
OK, merging this PR |
fanf
deleted the
bug_19873/saving_a_rule_with_deleted_directives_groups_does_not_correct_it
branch
https://issues.rudder.io/issues/19873
It adds the following display, which allows to remove the bad directive: