Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20036: Make a nice index page for logos #3907

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fixes #20036: Make a nice index page for logos #3907

merged 1 commit into from
Oct 5, 2021

Conversation

amousset
Copy link
Member

@amousset amousset commented Oct 1, 2021

@amousset
Copy link
Member Author

amousset commented Oct 1, 2021

PR updated with a new commit

RaphaelGauthier
RaphaelGauthier approved these changes Oct 5, 2021
View reviewed changes
logo/README.md Outdated
<table>
<tr>
<th colspan="4"></th>
</tr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line useful? If so, the value of colspan should be 3. But that's just a detail, it works fine as is!

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3907
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/45166/console)

@amousset
Copy link
Member Author

amousset commented Oct 5, 2021

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3907
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/45170/console)

@amousset
Copy link
Member Author

amousset commented Oct 5, 2021

OK, squash merging this PR

@amousset amousset force-pushed the ust_20036/make_a_nice_index_page_for_logos branch from f79b5d0 to d98d07f Compare October 5, 2021 13:43
@amousset amousset merged commit d98d07f into Normation:branches/rudder/7.0 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphaelGauthier RaphaelGauthier RaphaelGauthier approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Trigger test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amousset @Normation-Quality-Assistant @RaphaelGauthier