Fixes #4289: save directives based on a modified technique on library reload #405
Conversation
| * When a technique is updated, we may need to save back | ||
| * the Directive implementing it because the metadata.xml | ||
| * file may have changed. | ||
| * For example, a new optionnal variable may have been added. |
There was a problem hiding this comment.
As Jonathan said on Redmine:
The comments in code say this happens when a Technique is changed without a version increment, for example when adding an optional variable. What happens if a mandatory variable is added to a Technique without incrementing it's version and this code gets run?
I think that could be a big problem (all Directive will be saved without being validated, leading to a faulty deployment right after ),
but at last, the error will be prompted in the deployment error, showing that this Directive needs to be updated, and the user will need to go and update the Directive by himself.
I think it's acceptable to be able to get erros here, this feature is more helpful when developping technique (you are creating a new technique version, and you don't wan't to create new technique version everytime you get an error, or bugfix it ...) so I think our user would be glad to have errors directly ...
…n library reload
|
look's Good to me ! merging! |
…ted_when_metatechnique_changes Fixes #4289: save directives based on a modified technique on library reload
fanf
deleted the
bug_4289/expecting_reports_not_updated_when_metatechnique_changes
branch
No description provided.