Fixes #20133: Technique editor allows id with only case difference, do an error, but still save technique #4079
Conversation
|
PR updated with a new commit |
|
PR updated with a new commit |
ElaadF
force-pushed
the
bug_20133/technique_editor_allows_id_with_only_case_difference_do_an_error_but_still_save_technique
branch
from
4a4765d
to
8f171e6
Compare
| val techniques = techniqueRepository.getAll() | ||
| techniques.keySet.map(_.name.value).contains(bundleName.value) | ||
| techniques.values.map(_.name.toLowerCase).toList.contains(techniqueName.toLowerCase) |
There was a problem hiding this comment.
techniques.values produce Iterable[Technique] and contains do not apply on Iterable[A]
There was a problem hiding this comment.
you should advertise in the comment (at least) that it's a case insensitive comparision
| isNameTaken = isTechniqueNameExist(technique.name) | ||
| isIdTaken = isTechniqueIdExist(technique.bundleName) | ||
| _ <- (isNameTaken, isIdTaken) match { | ||
| case (true, true) => Failure(s"Technique name and ID must be unique. Name '${technique.name}' and ID '${technique.bundleName.value}' already used") |
There was a problem hiding this comment.
error message should state that the comparision is case insensitive
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…o an error, but still save technique
ElaadF
force-pushed
the
bug_20133/technique_editor_allows_id_with_only_case_difference_do_an_error_but_still_save_technique
branch
from
8a9b9a3
to
196ae97
Compare
https://issues.rudder.io/issues/20133