Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20708: Replacement of the screenshot in the README #4154

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Fixes #20708: Replacement of the screenshot in the README #4154

merged 1 commit into from
Feb 3, 2022

Conversation

juhnny5
Copy link
Contributor

@juhnny5 juhnny5 commented Feb 3, 2022

@juhnny5 juhnny5 requested a review from amousset February 3, 2022 12:54
ncharles
ncharles previously requested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has a ${version} rather than the correct version

@juhnny5
Copy link
Contributor Author

juhnny5 commented Feb 3, 2022

PR updated with a new commit

@juhnny5
Copy link
Contributor Author

juhnny5 commented Feb 3, 2022

PR updated with a new commit

@juhnny5
Copy link
Contributor Author

juhnny5 commented Feb 3, 2022

PR rebased

@juhnny5 juhnny5 force-pushed the arch_20708/replacement_of_the_screenshot_in_the_readme branch from cb6b180 to 1763019 Compare February 3, 2022 13:58
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 1763019 into Normation:branches/rudder/7.0 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

@ncharles ncharles ncharles left review comments

Assignees
No one assigned
Labels
Ready for merge Trigger test
Projects
None yet
Milestone
No milestone
5 participants
@juhnny5 @Normation-Quality-Assistant @ncharles @amousset @VinceMacBuche