Fixes #20721: kernel version doesn't show in the node page #4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amousset
reviewed
Feb 9, 2022
| <li><b>Name:</b> ${S.?("os.name." + sm.node.main.osDetails.os.name)}</li> | ||
| <li><b>Version:</b> ${sm.node.main.osDetails.version.value}</li> | ||
| <li><b>Service Pack:</b> ${sm.node.main.osDetails.servicePack.getOrElse("None")}</li> | ||
| <li><b>Architecture description:</b> ${sm.node.archDescription.getOrElse("None")}</li> |
There was a problem hiding this comment.
Suggested change
| <li><b>Architecture description:</b> ${sm.node.archDescription.getOrElse("None")}</li> | |
| <li><b>Architecture:</b> ${sm.node.archDescription.getOrElse("None")}</li> |
RaphaelGauthier
force-pushed
the
enh_20721/kernel_version_doesn_t_show_in_the_node_page
branch
from
bfd5655
to
be94b7e
Compare
|
Commit modified |
fanf
approved these changes
Feb 9, 2022
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20721