Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20971: Adapt the DSC code generator to the new ncf syntax #4234

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Apr 7, 2022

@Fdall Fdall requested a review from peckpeck April 7, 2022 10:21
Fixes #20971: Adapt the DSC code generator to the new ncf syntax
@Fdall
Copy link
Contributor Author

Fdall commented Apr 7, 2022

PR updated with a new commit

VinceMacBuche and others added 2 commits April 7, 2022 17:20
Fixes #20971: Adapt the DSC code generator to the new ncf syntax
@Fdall
Copy link
Contributor Author

Fdall commented Apr 7, 2022

PR updated with a new commit

Fixes #20971: Adapt the DSC code generator to the new ncf syntax
@Fdall
Copy link
Contributor Author

Fdall commented Apr 9, 2022

PR updated with a new commit

Fixes #20971: Adapt the DSC code generator to the new ncf syntax
@Fdall
Copy link
Contributor Author

Fdall commented Apr 9, 2022

PR updated with a new commit

Fixes #20971: Adapt the DSC code generator to the new ncf syntax
@Fdall
Copy link
Contributor Author

Fdall commented Apr 11, 2022

PR updated with a new commit

Fixes #20971: Adapt the DSC code generator to the new ncf syntax
@Fdall
Copy link
Contributor Author

Fdall commented Apr 11, 2022

PR updated with a new commit

None => "@{\n".to_string(),
Some(i) => format!(
"{} + @{{\n",
Some(i).unwrap()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is called "i"

@VinceMacBuche VinceMacBuche added the WIP Use that label for a Work In Progress PR that must not be merged yet label May 13, 2022
@fanf
Copy link
Member

fanf commented Aug 1, 2022

Closing this one since se changed the generation path for 7.2 and rudderc is not involved anymore for now

@fanf fanf closed this Aug 1, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger test WIP Use that label for a Work In Progress PR that must not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants