Fixes #4619: Improve json prettifier #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +81,53 @@ object RestUtils extends Loggable { | |||
| case _ => Failure("Prettify should only have one value, and should be set to true or false") | |||
| } | |||
|
|
|||
| def render(value: JValue): Document = { | |||
There was a problem hiding this comment.
I'm pretty sure that that code is mostly copy/pasted from somewhere.
So please:
- say from where, and which version (or branch, date) so that in the future, we will be able to know what changed in the original version (and so, we can follow security problem, for ex)
- clearly say what are the modification and what are the intents of each of them (so that comparison with the original is possible, and comparison with future version will be, too)
|
Updated with origin of the code, and some explanation about what changed here |
|
|
||
| /** | ||
| * Our own JSON render function to extends net.liftweb.json.JsonAst.render function | ||
| * All code is taken from JsonAst object from lift-json_2.10-2.5.1.jar (dépendency used in rudder 2.10 at least) |
There was a problem hiding this comment.
Could you give an URL to the code? It's open source :)
fanf
added a commit
that referenced
this pull request
Mar 17, 2014
…veJson_prettifier Fixes #4619: Improve json prettifier
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/4619