-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #22723: Backport scala 2.13 change for scala 3.0 migration #4783
Closed
fanf
wants to merge
17
commits into
Normation:master
from
fanf:arch_22723/backport_scala_2_13_change_for_scala_3_0_migration
Closed
Fixes #22723: Backport scala 2.13 change for scala 3.0 migration #4783
fanf
wants to merge
17
commits into
Normation:master
from
fanf:arch_22723/backport_scala_2_13_change_for_scala_3_0_migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR updated with a new commit |
1 similar comment
PR updated with a new commit |
String ++ String was converted into JArray(List(_, _))
…comprehenison. It would introduce withFilter calls allowing for safer parsing.
8af31bb
to
382a938
Compare
Superseeded by #4789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22723
Backport all changes compatible with scala 2.13. Commit 31d64d9 compensate for the drift since the PR was opened + for some changes that would require scala 3 or became unnecessary for now (moving
PropertyParser
in its own module for example).The changes are mainly:
()
and.apply
final
in front ofcase object
andobject
silencer
by now builtinnowarn
(and socom.github.ghik.silencer.silent
byscala.annotation.nowarn
)implicit val formats = Serialization.formats(NoTypeHints)
intoimplicit val formats = DefaultFormats
get
/getIO
inConfigService
)case
infor
loop when we extract a case class, typicallycase JString(ruleId) <- childs
Nothing seems to change code semantic anywhere (but welcomong a second pair of eyes).
If it's really the case, we should make the change in the oldest branch we support to avoid merge horror stories after that.