New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #22723: Backport scala 2.13 change for scala 3.0 migration #4789
Fixes #22723: Backport scala 2.13 change for scala 3.0 migration #4789
Conversation
8af31bb
to
382a938
Compare
PR updated with a new commit |
1 similar comment
PR updated with a new commit |
This PR is not mergeable to upper versions. |
54bd5e6
to
8be2d26
Compare
8be2d26
to
da3d601
Compare
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
String ++ String was converted into JArray(List(_, _))
…comprehenison. It would introduce withFilter calls allowing for safer parsing.
da3d601
to
28b1be8
Compare
https://issues.rudder.io/issues/22723
Backport all changes compatible with scala 2.13. Commit 31d64d9 compensate for the drift since the PR was opened + for some changes that would require scala 3 or became unnecessary for now (moving
PropertyParser
in its own module for example).The changes are mainly:
()
and.apply
final
in front ofcase object
andobject
silencer
by now builtinnowarn
(and socom.github.ghik.silencer.silent
byscala.annotation.nowarn
)implicit val formats = Serialization.formats(NoTypeHints)
intoimplicit val formats = DefaultFormats
get
/getIO
inConfigService
)case
infor
loop when we extract a case class, typicallycase JString(ruleId) <- childs
Nothing seems to change code semantic anywhere (but welcomong a second pair of eyes).
If it's really the case, we should make the change in the oldest branch we support to avoid merge horror stories after that.
There is warning because of place where the replacement of silencer is not yet useful. I will remove them in second time