Fixes #22864: Display inventory variables and values in node details #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Commit modified |
RaphaelGauthier
force-pushed
the
enh_22864/display_inventory_variables_and_values_in_node_details
branch
from
512ca6d
to
0eece88
Compare
|
The "Operating System" sub-tab is misnamed, only a part of it is linked to the OS. I would call it "System" or "System Information" |
|
PR updated with a new commit |
amousset
reviewed
Jun 12, 2023
| <h3 class="page-title foldable" onclick="$('.variables-table-container').toggle(); $(this).toggleClass('folded');">Inventory variables <i class="fa fa-chevron-down"></i></h3> | ||
| <div class="variables-table-container"> | ||
| <div class="alert alert-info"> | ||
| These are the node inventory variables that can be used in directive inputs. |
There was a problem hiding this comment.
Suggested change
| These are the node inventory variables that can be used in directive inputs. | |
| These are the node inventory variables that can be used in directive inputs with the `${node.inventory[NAME]}` syntax. |
|
Also missing scala formating |
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
RaphaelGauthier
force-pushed
the
enh_22864/display_inventory_variables_and_values_in_node_details
branch
from
44cff99
to
46c4ee7
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22864