Fixes #22388: Bad report maching when reportid are present #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
bug_22388/bad_report_maching_when_reportid_are_present
branch
from
6ba75af
to
b44b0e9
Compare
|
PR updated with a new commit |
|
We may remove function replaceCFEngineVars or is it used somewhere else ? probably in another PR |
VinceMacBuche
approved these changes
Jul 19, 2023
|
This PR is not mergeable to upper versions. |
It's used in the case without |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_22388/bad_report_maching_when_reportid_are_present
branch
from
999e6f7
to
bfad70e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22388
$more lenient: now, we only compare that what is before the$is identical (ie whole string when no variable, nothing when the variable is at the begining, etc)