Fixes #23084: Remove constraint on component name pattern for matching reports #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
PR updated with a new commit |
VinceMacBuche
approved these changes
Aug 30, 2023
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
arch_23084/remove_constraint_on_component_name_pattern_for_matching_reports
branch
from
3415d48
to
8d1f7ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23084
Next step of #4897 and #4899
reportIdreportIdfield (default to0for case without a validreportId) forComponentValueStatusReportand addapt grouping in consequence, so that now, two report with same value but different report Id are splitted apart.componentNamethenreportIdthenkeyValueto minimize change (reportId first look like we should have something on top ofComponentStatusReportwith Id, which doesn't match well the current reports structure where each report brings reportid)