Ref #2973 : Automatic reports cleaning #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Value("${rudder.batch.reportsCleaner.delete.TTL}") | ||
| var reportCleanerDeleteTTL = 90 | ||
|
|
||
| @Value("${rudder.batch.reportsCleaner.frequency}") |
There was a problem hiding this comment.
It would be better to use values defined in object FrequencyBuilder for that, but I'm not sure it is possible: I believe annotation only takes static modifier, so perhaps a "final" will be needed for vals.
|
Just testing - @Normation/documentors should also be concerned by this change. |
|
@Normation/administrators : sorry for the spam! |
|
|
||
| override val logger = ReportLogger | ||
| private var currentState: CleanerState = IdleCleaner | ||
| private var lastRun: DateTime = DateTime.now() |
There was a problem hiding this comment.
By habits, use the visibility private[this]
…n I/O with reports database
…ogger, and better indentation
…minutes in reports cleaning
…c reports cleaning section
…utomaticReportsCleaning helper object instead
…tsClean*, add comments and correct comments
|
I close this pull request has it had been retargeted to master, see #9 instead |
fanf
referenced
this pull request
in fanf/rudder
Dec 4, 2013
…Save_popup Ust 4180/dev 4182 manage directive on save popup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following ticket #2972, this update goal is to provide a way to automate reports cleaning.
You have to define in your property files the parameters of your reports cleaning process
this is linked to http://www.rudder-project.org/redmine/issues/2973
You can ignore the commit related to ticket #2972 #2974 #2976, as they are treated in #4 and they will disapear when the first pull request will be accepted