Arc 4778/4782 split interpolation variable parsing and binding #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -203,6 +202,7 @@ class SystemVariableServiceImpl( | |||
|
|
|||
| val varManagedNodes = systemVariableSpecService.get("MANAGED_NODES_NAME").toVariable(children.map(_.hostname)) | |||
| val varManagedNodesId = systemVariableSpecService.get("MANAGED_NODES_ID").toVariable(children.map(_.id.value)) | |||
| //IT IS VERY IMPORTANT TO SORT SYSTEM VARIABLE HERE: see ticket #4859 | |||
There was a problem hiding this comment.
shouldn't it have been in the other commit ?
There was a problem hiding this comment.
It's just the comment that was missing (bad rebase, I think)
|
Appart from comments related remarks, this looks good to me |
Massive speed gain (x10) and massive code simplification
|
PR updated & rebased on last master |
|
awesome, thank you ! |
ncharles
added a commit
that referenced
this pull request
May 19, 2014
…ariable_parsing_and_binding Arc 4778/4782 split interpolation variable parsing and binding
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive refactoring to split parsing of interpolation variable in directive parameters from there expansion when we build node configuration.
Completly change the way we look for interpolation variables from plain regex with a "while something change, try to apply a regex replace" logic, to a real parser + interpretation.
Also, clean up the data structures used: