Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23684: Migrate rudder-templates-cli package to zio-json #5148

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Oct 31, 2023

https://issues.rudder.io/issues/23684

The first one in the series of 'migration from lift-json to zio-json' 馃コ

A Json.Obj is just a Chunk[(String, Json)] as a collection of pair in zio-json

@clarktsiory clarktsiory requested a review from fanf October 31, 2023 16:31
@clarktsiory clarktsiory force-pushed the arch_23684/migrate_rudder_templates_cli_package_to_zio_json branch from 537dfca to 4603b9e Compare October 31, 2023 16:40
@clarktsiory
Copy link
Contributor Author

Commit modified

@clarktsiory clarktsiory force-pushed the arch_23684/migrate_rudder_templates_cli_package_to_zio_json branch from 4603b9e to 7c97c76 Compare October 31, 2023 16:45
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This one was alsmost possible with sed 馃槄

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 7c97c76 into Normation:master Nov 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants