Fixes #23735: Exception when bad input for inventory duration config #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
fanf
reviewed
Nov 16, 2023
webapp/sources/rudder/rudder-web/src/main/scala/bootstrap/liftweb/RudderConfig.scala
Outdated
Show resolved
Hide resolved
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_23735/exception_when_bad_input_for_inventory_duration_config
branch
from
bee959b
to
6e5580f
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23735
The only message that an
ExceptionInInitializerErrorprovides isnull, so we do not want to show the message but the cause instead...Also for config value errors, adopting a standard error format and catching errors could always be beneficial so I used that to improve the errors logs during boot when config errors should prevent the server from running...
I also took into account the suggestions to add comments to the sample configuration file, and use the main value
rudder.batch.reportsCleaner.deleteLogReport.TTLin the configuration in favor ofrudder.batch.reportsCleaner.deleteReportLog.TTL(which we do not use in the code)