Fixes #23837: Enforce change request and workflow table schema #5233
Conversation
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
| select count(*) | ||
| from information_schema.columns | ||
| where table_name = $tableName | ||
| and column_name = $columnName |
There was a problem hiding this comment.
]we have a convention of always using . ${Var} for interpolation
| where table_name = $tableName | ||
| and column_name = $columnName | ||
| and is_nullable = 'YES' | ||
| """.query[Int].unique.map(_ > 0) |
There was a problem hiding this comment.
This method has been written several times.
Shouldn't it be time to put it in a DbCommonMigration or something?
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_23837/enforce_change_request_and_workflow_table_schema
branch
from
80b3009
to
a900c33
Compare
https://issues.rudder.io/issues/23837
We need to add
NOT NULLconstraint to the change-validation plugin tables, in order to enforce the table schema (until now there does not seem to be anullvalue that has been written in the table, in that case the migration would fail but the user would have a nice error log). I added database tests.Note that this PR is very similar to #5232