Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24090: Score table migration #5356

Merged
merged 1 commit into from Jan 31, 2024
Merged

Fixes #24090: Score table migration #5356

merged 1 commit into from Jan 31, 2024

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the bug_24090/score_table_migration branch 2 times, most recently from da9897a to 1baaaa1 Compare January 29, 2024 15:10
fanf
fanf approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected.

We still need to find a general pattern to not to write the same SQL both here and in the schema SQL file, because it's extremely fastidious and error prone.

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 950cf3f into Normation:branches/rudder/8.1 Jan 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VinceMacBuche @Normation-Quality-Assistant @fanf