Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25164: When agent version is missing in inventory, we get a security token error #5774

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 18, 2024

https://issues.rudder.io/issues/25164

Check for missing agent version in parsing to get a correct error message.

Relax a bit the check on node fact transformation to make it easier to spot that kind of problem.

image

@fanf fanf requested a review from VinceMacBuche July 18, 2024 15:18
@fanf
Copy link
Member Author

fanf commented Jul 19, 2024

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5774
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/87333/console)

@fanf
Copy link
Member Author

fanf commented Jul 22, 2024

OK, squash merging this PR

fanf and others added 3 commits July 22, 2024 14:00
…/scala/com/normation/inventory/provisioning/fusion/FusionInventoryParser.scala

Co-authored-by: Alexis Mousset <alexis.mousset@rudder.io>
…rc/main/scala/com/normation/inventory/provisioning/fusion/FusionInventoryParser.scala

Fixes #25164: When agent version is missing in inventory, we get a security token error
@fanf fanf force-pushed the bug_25164/when_agent_version_is_missing_in_inventory_we_get_a_security_token_error branch from 8111cad to 7eed947 Compare July 22, 2024 12:00
@fanf fanf merged commit 7eed947 into Normation:branches/rudder/8.1 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants