Fixes #5501: Add Twitter Bootstrap CSS (not js) #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
ust_5293/dev_5501_add_twitter_bootstrap_css
branch
from
c6d3715
to
8f49fc1
Compare
|
Nice Pr for boosting personnal stats !! I think the css and js is ok !! we will be very happu to switch to minified files ones when everythin will be testest completelely |
VinceMacBuche
added a commit
that referenced
this pull request
Sep 8, 2014
…trap_css Fixes #5501: Add Twitter Bootstrap CSS (not js)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That pull request allows to use Twitter Bootstrap CSS and JS without breaking everything in Rudder.
See http://stackoverflow.com/questions/25552144/add-bootstrap-js-css-in-a-subparty-of-a-page-or-use-a-global-no-conflic-or-names for the technical limitation.
The solution was to rewrite CSS with a prefix, namely ".tw-bs" thanks to a LESS online processor (for remaining, it was: http://less2css.org/)
To use it, use the tw-bs component name prefixed with the "tw-bs" class. For example, to use the progree bar component, one will write:
<div class="tw-bs progress">For using the JS part, I was forced to add "no-conflict" for all standard element of bootstrap (buttons, alerts, modal, tabs, etc). If at some point we want to switch to bootstrap version, we will need to use them everywhere in Rudder (i.e: we can't simply use a Bootstrap button for one new visual element, we will need to change all Rudder buttons to use bootstrap).